perf: Implement tbl_subassign_col() in C
#1368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
reviewed
Sep 5, 2022
| // x_names: names of x | ||
| // n_old: number of elements with some property | ||
| // j_max: maximum value of j | ||
| // j_/j: SEXP and native version of bare vector |
There was a problem hiding this comment.
Use j_ffi vs j? This way it's immediately clear which does what.
|
|
||
| // Compute j from j_, converting 1-based j_ to zero-based j | ||
| R_xlen_t n_j = Rf_xlength(j_); | ||
| R_xlen_t* j = (R_xlen_t*)R_alloc(n_j + 1, sizeof(R_xlen_t)); |
There was a problem hiding this comment.
Is there a reason not to use a raw vector here? Just asking because we usually renounce to manage memory only in very specific cases.
There was a problem hiding this comment.
Same remark for allocs below. Another reason to manage memory manually is that it makes it clearer when things are not needed anymore, so this has a self-documenting value.
| } | ||
|
|
||
| // Allocate output vector and output names with final size | ||
| SEXP xo = Rf_allocVector(VECSXP, n_xo); |
| SEXP xo = Rf_allocVector(VECSXP, n_xo); | ||
| Rf_copyMostAttrib(x, xo); | ||
|
|
||
| SEXP xo_names = Rf_allocVector(STRSXP, n_xo); |
|
|
||
| // Compute j from j_, converting 1-based j_ to zero-based j | ||
| R_xlen_t n_j = Rf_xlength(j_); | ||
| R_xlen_t* j = (R_xlen_t*)R_alloc(n_j + 1, sizeof(R_xlen_t)); |
There was a problem hiding this comment.
Could you have used vec_as_location() upstream to avoid having to deal with double vectors? I imagine tibble doesn't need support for long vectors in the column dimension.
| // Add sentinel value | ||
| j[n_j] = -1; | ||
|
|
||
| // Compute j_max and n_old |
|
|
||
| // Set output row names | ||
| // FIXME: Reuse original vector? | ||
| SEXP new_row_names_ = Rf_allocVector(INTSXP, 2); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1353.